Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of localization related editor settings #89135

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

timothyqiu
Copy link
Member

  • interface/editor/localize_settings:
    • It's not dedicated to the Editor Settings dialog. It's used by most EditorInspector-based editor UI. Mainly Project Settings and Editor Settings, but also used in places like the advanced import settings.
    • It's not disabled by default.
  • interface/inspector/default_property_name_style
    • Raw is snake_case only, not related to GDScript vs C#.
    • Capitalized is not simply String.capitalize. Extra care is taken, like capitalization of macOS and special handling of articles and conjunctions.

Also did a bit rewording. Previously, it sounds like localize_settings and default_property_name_style are a base setting and an override. But they control different parts of the editor although both related to EditorInspector (the control).

@timothyqiu timothyqiu added this to the 4.3 milestone Mar 4, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner March 4, 2024 11:14
@akien-mga akien-mga merged commit 13ba673 into godotengine:master Mar 4, 2024
16 checks passed
@timothyqiu timothyqiu deleted the l10n-desc branch March 4, 2024 13:14
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants