-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cursor_set_custom_image()
method
#88970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am to assume this will require some GDExtension binding compatibility code of sorts. |
Compatibility for what? It doesn't change any bindings |
KoBeWi
force-pushed
the
ImageCursor2D
branch
from
February 28, 2024 19:02
04f2dfb
to
73bbcf6
Compare
akien-mga
reviewed
Feb 28, 2024
akien-mga
reviewed
Feb 28, 2024
KoBeWi
force-pushed
the
ImageCursor2D
branch
from
February 28, 2024 19:32
73bbcf6
to
3aeb4a5
Compare
akien-mga
approved these changes
Feb 28, 2024
AThousandShips
approved these changes
Feb 29, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cursor_set_custom_image()
has image in name, mentions image in the description, but the resource it expects is actually Texture2D. Moreover, the Texture2D is converted to Image inside the method and every DisplayServer implementation has pretty much the same code to do so...This PR