Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit: Update to clang-format 17.0.6 and black 24.2.0 #88959

Merged

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Feb 28, 2024

A big advantage of the move to pre-commit is that we can pin style checking dependencies for everyone, so there's no more concern updating to clang-format 17 even though its output differs slightly from versions 13 to 16 which we supported prior to this.

@akien-mga akien-mga added enhancement topic:buildsystem cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:codestyle cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Feb 28, 2024
@akien-mga akien-mga added this to the 4.3 milestone Feb 28, 2024
@akien-mga akien-mga requested review from a team as code owners February 28, 2024 13:27
@@ -1415,7 +1415,7 @@ static void gdextension_editor_help_load_xml_from_utf8_chars(const char *p_data)
#endif
}

#define REGISTER_INTERFACE_FUNC(m_name) GDExtension::register_interface_function(#m_name, (GDExtensionInterfaceFunctionPtr)&gdextension_##m_name)
#define REGISTER_INTERFACE_FUNC(m_name) GDExtension::register_interface_function(#m_name, (GDExtensionInterfaceFunctionPtr) & gdextension_##m_name)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is technically "wrong" as per our code style for references, but it seems whatever fix they made in clang-format 17 for the handling of math operators in macros has a bit of an issue with reference/pointer operators.

Overall it shouldn't be a big issue, and maybe future clang-format versions will fix it back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akien-mga is this issue reported?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akien-mga akien-mga merged commit 7434f8b into godotengine:master Feb 29, 2024
16 checks passed
@akien-mga akien-mga deleted the pre-commit-clang-17.0.6-black-24.2.0 branch February 29, 2024 13:00
@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:buildsystem topic:codestyle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants