-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split PropertyInfo and MethodInfo off from Object into their own separate files. #88831
base: master
Are you sure you want to change the base?
Split PropertyInfo and MethodInfo off from Object into their own separate files. #88831
Conversation
527fa29
to
4c78b0a
Compare
Hmm, I'm noticing that the Linux build is failing because |
I actually managed to find a different solution so that structs can work without relying on splitting If others don't like the change of splitting of |
4c78b0a
to
244a8ef
Compare
I've resolved the conflicts on this branch and left the |
244a8ef
to
0f35529
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long wait. For me this is sensible, but someone from core should take a look at this as well.
Should be safe to merge, as I just checked that there were no changes of MethodInfo/PropertyInfo within the last few months.
Makes sense to me conceptually. Could use a rebase to make sure it still works. |
0f35529
to
da81925
Compare
To avoid cyclic dependencies in a different PR I am working on (#82198), I need to be able to include PropertyInfo and MethodInfo without also including Object. Additionally, separating out these structs helps keep Object.h/cpp focused on just Object stuff.