Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XR] Fix building on MinGW #88724

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[XR] Fix building on MinGW #88724

merged 1 commit into from
Feb 23, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Feb 23, 2024 •
edited
Loading

Destructor was defined in multiple places due to multiple inheritance

Using MinGW 13.2.0

@AThousandShips
[XR] Fix building on MinGW
efeb6be 
Destructor was defined in multiple places due to multiple inheritance
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 23, 2024
@AThousandShips AThousandShips requested a review from a team February 23, 2024 18:13
dsnopek
dsnopek approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, especially since we aren't doing anything in this destructor :-)

@akien-mga akien-mga merged commit 41f39cf into godotengine:master Feb 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the xr_build_fix branch February 23, 2024 21:30
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:buildsystem topic:xr
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @akien-mga @dsnopek