Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose OpenXR hand tracker handles #88566

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Expose OpenXR hand tracker handles #88566

merged 1 commit into from
Feb 20, 2024

Conversation

devloglogan
Copy link
Contributor

Provides GDExtension access to hand tracking XRHandTrackerEXT handles via OpenXRAPI/OpenXRAPIExtension. Access to these is needed in order to implement OpenXR vendor extension XR_FB_hand_tracking_mesh in the godot_openxr_vendors repo.

@Mickeon Mickeon requested review from a team February 19, 2024 21:15
@Mickeon
Copy link
Contributor

Mickeon commented Feb 19, 2024

Exciting crossover between GDExtension and XR teams

@Mickeon Mickeon added this to the 4.x milestone Feb 19, 2024
dsnopek
dsnopek reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For the most part this looks good to me. :-) Just one uncertainty with regard to naming.

modules/openxr/openxr_api_extension.cpp Outdated Show resolved Hide resolved
@AThousandShips AThousandShips changed the title expose OpenXR hand tracker handles Expose OpenXR hand tracker handles Feb 20, 2024
dsnopek
dsnopek approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 20, 2024
@akien-mga akien-mga merged commit 02fdf26 into godotengine:master Feb 20, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon left review comments

@dsnopek dsnopek dsnopek approved these changes

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
enhancement topic:gdextension topic:xr
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@devloglogan @Mickeon @akien-mga @dsnopek @m4gr3d