Editor: Focus value editor on type change in Dictionary and Array editors

[EmrysMyrddin]

In the inspector, when editing an exported Dictionary property, the focus is lost once a type is chosen for the new key, the new value or an existing value.

Enregistrement.de.l.ecran.2024-02-14.a.14.10.45.mov

This PR is fixing this by focusing the editor property after changing the type:

Enregistrement.de.l.ecran.2024-02-14.a.14.13.18.mov

[KoBeWi]

The focus is still lost when pressing the Add Key/Value Pair button. Any chance this could also be improved?

EDIT:
Seems like it only happens right after changing type 🤔 If you edit a value and then add it, the focus is preserved.

[ajreckof]

This PR was superseded by #88231 as it fix the focus loss. But I feel like the idea of switching the focus from the change_type button to the EditorProperty is a good idea and could be a great improvement.

[EmrysMyrddin]

@ajreckof Thank you for the update, should I continue to work on this then ?

[ajreckof]

I think the switch of focus would be a great improvement and I would 100% be for it. And I don't see any reasons it wouldn't be accepted. If you need any help with it feel free to send me a message on rocket chat.

[EmrysMyrddin]

Wow, @ajreckof great work on this refactor! The code is muuuch clearer now, it's even cleaner and more understandable to fix the focus now!

I've rebased and fixed issue pointed out by @KoBeWi, the problem was that the focus was taken only on property update, which doesn't happens if you open the change type popup but chose the same type already selected.

[EmrysMyrddin]

After looking at @ajreckof refactoring, I understood that the Array Editor works pretty much the same, so I also made the change for it, so that both Dictionary and Array editors have the same behaviour.

[AThousandShips]

Please squash your commits into one, see here

[EmrysMyrddin]

Sure, done ✅

[EmrysMyrddin]

Should keep the branch as much up to date as possible by rebasing on master on a regular bases ?

[KoBeWi]

Only when there are conflicts or a long time has passed (i.e months). Usually it's not necessary.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[Calinou]

Tested locally, it works as expected. This is a nice usability boost for keyboard usage 🙂

(Sorry, forgot to refresh before posting the review.)