FileSystem dock: Fix opening a Linux terminal #88173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
platform:windows
topic:porting
platform:linuxbsd
and removed
platform:windows
labels
capnm
force-pushed
the
240210-fix-fsdock-open_terminal
branch
from
d9e3151
to
717b2e6
Compare
capnm
force-pushed
the
240210-fix-fsdock-open_terminal
branch
from
717b2e6
to
e64ec01
Compare
The previous implementation of opening a terminal in the FileSystem dock was causing errors due to the use of a bash builtin command that does not work outside the shell. This resulted in the following error messages: ERROR: Could not create child process: command at: execute (drivers/unix/os_unix.cpp:553) ERROR: Could not create child process: command at: execute (drivers/unix/os_unix.cpp:553) ... To resolve this issue, + the command is now executed inside a bash shell, + if the `terminal_emulator_flags` editor option is empty, the working directory for gnome-terminal and urxvt is now properly set.
capnm
force-pushed
the
240210-fix-fsdock-open_terminal
branch
from
e64ec01
to
8e8f8e9
Compare
|
Rebased to tip and tested KDE Plasma on Arch Linux: Without this PR also broken: current tip + PR OK:
|
akien-mga
changed the title
akien-mga
approved these changes
Feb 14, 2024
|
I thought Either way, it's not very important as the editor on Linux/*BSD will pretty much always have Bash available. |
Calinou
approved these changes
Feb 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of opening a terminal
in the FileSystem dock was causing errors due to the use
of a bash builtin command that does not work outside the shell.
This resulted in the following error messages:
To resolve this issue,
terminal_emulator_flagseditor option is empty,the working directory for gnome-terminal and urxvt is now properly set.
Tested only on GNOME platforms debian/ubuntu:
godot4.3devX -v -e...
Opening terminal emulator: gnome-terminal --working-directory ... /00-test-new_projects/new-project1/new_folder/test folder/
Opening terminal emulator: urxvt -cd ... /00-test-new_projects/new-project1/new_folder/test folder