Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3.x references in the pull request template #88159

Merged

Conversation

adamscott
Copy link
Member

As 98% of the PRs target 4.x (don't quote me for this) and as these 3.x reference where something critical when we were developing 3.x and 4.x (on master) fully in parallel, we should remove these references as they are not relevant (for the great majority of users) anymore.

This PR was suggested in part by Nat from the comms after a review of the issues/PR workflow.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with removing the 3.x notice given the development focus is increasingly on 4.x nowadays. We can manually ask for a 3.x version of the PR if it's really needed, but this will be reserved for important bug fixes now.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought to do this too.

But if we're adding a first-interaction welcome message with an action, then we can probably remove the whole template. This HTML comment in your OP when you open a PR is always a bother IMO.

@akien-mga akien-mga added this to the 4.3 milestone Feb 10, 2024
@akien-mga akien-mga merged commit df3e978 into godotengine:master Feb 12, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants