thorvg: Re-enable thread support, made opt-in upstream #88053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
akien-mga
commented
Feb 7, 2024
akien-mga
commented
- Fixup to ThorVG: update from v0.12.1 to v0.12.3 #87612.
- Fixes Importing SVG's in 4.3.dev with commit 73589f6 is crashing #87788.
- Fixes ThorVG regression causing potentially corrupted SVGs #87962.
akien-mga
added
bug
topic:thirdparty
regression
cherrypick:4.2
akien-mga
commented
Feb 7, 2024
| @@ -38,10 +38,10 @@ namespace tvg { | |||
| { | |||
| Key* key = nullptr; | |||
|
|
|||
| ScopedLock(Key& key) | |||
| ScopedLock(Key& p_key) | |||
There was a problem hiding this comment.
@hermet FYI, I was getting a -Wshadow warning from GCC here.
Happy to make a PR upstream if this kind of change looks acceptable, possibly with a different naming convention if there's one you favor.
|
I'll yolo merge as I'm about to build 4.3-dev3 and would like this regression fixed in that build. |
|
I forgot that this is only default within the meson, sorry. |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.