Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Enabled secure restorable state. #88050

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 7, 2024

We aren't storing any custom data in it, but adding it prevents WARNING: Secure coding is automatically enabled for restorable state! However, not on all supported macOS versions of this application warning on the app start.

@bruvzg bruvzg requested a review from a team as a code owner February 7, 2024 09:02
@akien-mga akien-mga added this to the 4.3 milestone Feb 7, 2024
@akien-mga akien-mga added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Feb 7, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Is this relevant to cherry-pick to 3.x?

@bruvzg
Copy link
Member Author

bruvzg commented Feb 7, 2024

Is this relevant to cherry-pick to 3.x?

Yes.

@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Feb 7, 2024
@akien-mga akien-mga merged commit 08eaeff into godotengine:master Feb 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

akien-mga commented Mar 11, 2024

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.

@akien-mga akien-mga removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Mar 11, 2024
@akien-mga
Copy link
Member

Cherry-picked for 3.6.
Cherry-picked for 3.5.4.

@akien-mga akien-mga removed cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants