Extract BottomPanel from EditorNode #87760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbdev
force-pushed
the
extract-bottom-dock
branch
from
47eb31e
to
ac74662
Compare
KoBeWi
reviewed
Feb 18, 2024
| @@ -38,6 +38,7 @@ | |||
| #include "editor/editor_settings.h" | |||
| #include "editor/editor_string_names.h" | |||
| #include "editor/editor_undo_redo_manager.h" | |||
| #include "editor/gui/editor_bottom_panel.h" | |||
There was a problem hiding this comment.
Worth checking whether editor_node.h can be removed (in all files).
EDIT:
Nevermind, the bottom panel would have to be singleton itself to do that.
KoBeWi
reviewed
Feb 18, 2024
KoBeWi
reviewed
Feb 18, 2024
kitbdev
force-pushed
the
extract-bottom-dock
branch
from
ac74662
to
f6fb448
Compare
kitbdev
force-pushed
the
extract-bottom-dock
branch
from
f6fb448
to
eb6ca91
Compare
|
Rebased after #86378 and changed to use |
KoBeWi
approved these changes
Feb 23, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EditorDockManagerfromEditorNode#84193Extracts all functionality related to the bottom panel from EditorNode.
No functionality should change.
Details
editor/gui/editor_bottom_panel.h/cppbottom_hb, since it was never used anywhere.bool p_visibleparam tomake_item_visible()(make_bottom_panel_item_visible()) since EditorNode needed it.save_layout_to_config()andload_layout_from_config().set_process(true)as part of Fix broken bottom panel switching #72420, this can be removed in the future when a better fix is made for it.