Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a possible crash when importing an OGG file with zero-length packets #87246

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix a possible crash when importing an OGG file with zero-length packets #87246

merged 1 commit into from
Feb 14, 2024

Commits on Jan 16, 2024

  1. Fixed an issue that could cause a crash when encountering a zero-leng… 

    …th packet in an OGG stream.

A zero-length memcpy into a null pointer itself does not fail, but for gcc with optimizations, this can cause incorrect code to be generated further down the line since the pointer is then assumed to be non-null.
Now stripping zero-length packets and pages without packets from the OggPacketSequence during import. This prevents various warning and error messages for files that end on a zero-length packet.
    @bs-mwoerner
    bs-mwoerner committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    a4db4ae View commit details
    Browse the repository at this point in the history