Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing descriptions to PrimitiveMesh and SoftBody3D #87011

Merged

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Jan 9, 2024

This PR ...💤💤...
... This brings them to 100% completion.

Pressure coefficient source: https://arxiv.org/ftp/physics/papers/0407/0407003.pdf

May require the insight from the Physics team for the missing SoftBody3D descriptions.

@Mickeon Mickeon requested a review from a team as a code owner January 9, 2024 16:09
@AThousandShips AThousandShips added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jan 9, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Jan 9, 2024
@Mickeon Mickeon force-pushed the missing-description-primitive-mesh branch from a14a923 to 056fc84 Compare January 9, 2024 16:29
@Mickeon Mickeon force-pushed the missing-description-primitive-mesh branch from 056fc84 to a33777d Compare January 9, 2024 16:31
@AThousandShips AThousandShips requested a review from a team January 9, 2024 16:59
@hemu0069
Copy link

nice one

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PrimitiveMesh description looks good!

The SoftBody stuff also seems fine, but I'm less knowledgeable about that

@akien-mga akien-mga merged commit 378b3ca into godotengine:master Jan 15, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Mickeon Mickeon deleted the missing-description-primitive-mesh branch January 15, 2024 13:01
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants