Make default options of int value track refer to RESET animation #86630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
value-track-default-option
branch
4 times, most recently
from
7362593
to
cab26d2
Compare
KoBeWi
reviewed
Jan 1, 2024
KoBeWi
approved these changes
Jan 1, 2024
fire
changed the title
|
The title of the commit can be |
TokageItLab
force-pushed
the
value-track-default-option
branch
from
cab26d2
to
eecfe5d
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the default track options copy the RESET animation if it exists when keying the value/bezier track. Also, fix defaults for some new Variant types, supersedes/closes #62190.
I believe the default for Int should be Continuous + Nearest as I mentiond in godotengine/godot-proposals#8512, but it not will done in 4.x because it may cause confusing. In AnimationTree, the default is to force the conversion to Continuous internally by #86629, so I think it should be no problem.
The PR that copies an existing option to the RESET track as opposed to this PR is #85540.