Emit slider's drag_started
signal before the first value change
#86377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86370
#80916 made
value_changed
to emit afterdrag_started
in order to fix ColorPicker's deferred mode. But the actual value change is still beforedrag_started
.It was then impossible to safely ignore
value_changed
signal when dragging, because you'll miss thevalue_changed
signal when pressing down the mouse button.This PR:
drag_started
before the initial value change, so users can get the correct start value when handling the signal.drag_ended
can correctly tell that the value is changed if the user simply clicks somewhere on the slider other than the grabber.