Replace GDVIRTUAL_CALL with GDVIRTUAL_REQUIRED_CALL where applicable
#86169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
approved these changes
Dec 20, 2023
dsnopek
added
the
cherrypick:4.2
YuriSizov
approved these changes
Dec 20, 2023
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of
GDVIRTUAL_CALLimplementations were used as booleans for a check exclusively to see if they're implemented, throwing an error if they weren't. This functionality is already present inGDVIRTUAL_REQUIRED_CALL, though it was added later on compared to the bulk of these implementations, so this PR updates them accordingly.