Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the description of the method get_connection_list in GraphEdit #86161

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Update the description of the method get_connection_list in GraphEdit #86161

merged 1 commit into from
Dec 16, 2023

Conversation

ZeferinoI
Copy link
Contributor

@ZeferinoI ZeferinoI commented Dec 14, 2023 •
edited by AThousandShips
Loading

The structure of the connection (of type dictionary) in returned array is actually { from_port: 0, from_node: "GraphNode name 0", to_port: 1, to_node: "GraphNode name 1" }

@ZeferinoI
Update the description of the method get_connection_line in GraphEdit…
53ab38a 
….xml

The form should be like { from_port: 0, from_node: "GraphNode name 0", to_port: 1, to_node: "GraphNode name 1" }
@ZeferinoI ZeferinoI requested a review from a team as a code owner December 14, 2023 15:46
@AThousandShips AThousandShips added enhancement documentation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 14, 2023
@AThousandShips AThousandShips added this to the 4.3 milestone Dec 14, 2023
@YuriSizov YuriSizov mentioned this pull request Dec 15, 2023
Merged
2 tasks
@ZeferinoI ZeferinoI closed this Dec 16, 2023
@ZeferinoI ZeferinoI deleted the patch-1 branch December 16, 2023 05:09
@ZeferinoI ZeferinoI restored the patch-1 branch December 16, 2023 05:27
@ZeferinoI ZeferinoI reopened this Dec 16, 2023
@ZeferinoI ZeferinoI closed this Dec 16, 2023
@ZeferinoI ZeferinoI deleted the patch-1 branch December 16, 2023 05:30
@ZeferinoI ZeferinoI restored the patch-1 branch December 16, 2023 05:31
@ZeferinoI ZeferinoI reopened this Dec 16, 2023
@ZeferinoI ZeferinoI changed the title Update the description of the method get_connection_line in GraphEdit Update the description of the method get_connection_list in GraphEdit Dec 16, 2023
@YuriSizov YuriSizov merged commit 9c425c5 into godotengine:master Dec 16, 2023
30 checks passed
@YuriSizov
Copy link
Contributor

Thanks! And congratulations on your first merged Godot contribution!

@ZeferinoI
Copy link
Contributor Author

Thanks! And congratulations on your first merged Godot contribution!

Oh，I would say THANK YOU! You encouraged me to do this when I was (am still) just a rookie to github and godot.

@ZeferinoI ZeferinoI deleted the patch-1 branch December 17, 2023 06:42
@akien-mga akien-mga changed the title Update the description of the method get_connection_list in GraphEdit Update the description of the method get_connection_list in GraphEdit Dec 17, 2023
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geometror Geometror Geometror approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Return of GraphEdit.get_connection_list() seems to be not like what's described in documentation
4 participants
@ZeferinoI @YuriSizov @Geometror @AThousandShips