Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quitting search bar in doc causes "Parameter "p_node" is null" #86020

Closed
wants to merge 1 commit into from
Closed

Fix quitting search bar in doc causes "Parameter "p_node" is null" #86020

wants to merge 1 commit into from

Conversation

jsjtxietian
Copy link
Contributor

Fixes #85847

@Chaosus Chaosus added this to the 4.3 milestone Dec 11, 2023
@jsjtxietian jsjtxietian force-pushed the fix-search-bar-in-doc branch from 5a7758d to 103a596 Compare December 11, 2023 10:48
@daustria
Copy link
Contributor

@jsjtxietian im interested in learning a bit more of the editor part of the codebase. would you (or maybe someone else) be able to explain the changes at a high level? could also talk on chat.godotengine if this is inappropriate.

@jsjtxietian
Copy link
Contributor Author

Hi, which part causes confusion for you? you can just comment on these lines and I'm happy to explain it.
But basically what I do to fix the bug here is to refer to FindReplaceBar for the correct behaviour, check whether FindBar lacks any function compared to it and find the fix.

Maran23
Maran23 approved these changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@Maran23 Maran23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Same fix as done for FindReplaceBar in #83335

@KoBeWi KoBeWi modified the milestones: 4.3, 4.4 Jul 26, 2024
@Repiteo Repiteo modified the milestones: 4.4, 4.5 Feb 24, 2025
@Repiteo
Copy link
Contributor

Repiteo commented Mar 3, 2025

Superseded by #83335

@Repiteo Repiteo closed this Mar 3, 2025
@Repiteo Repiteo removed this from the 4.5 milestone Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@Maran23 Maran23 Maran23 approved these changes

Assignees
No one assigned
Labels
archived bug topic:editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scene/main/node.cpp:1766 - Parameter "p_node" is null. in Godot 4.2
7 participants
@jsjtxietian @daustria @Repiteo @Maran23 @AThousandShips @KoBeWi @Chaosus