Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsigned char cast ifdef to work around -Wtype-limits warnings #85500

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Add unsigned char cast ifdef to work around -Wtype-limits warnings #85500

merged 1 commit into from
Nov 29, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 29, 2023

Suppresses build warnings on ARM Linux.

@bruvzg bruvzg added this to the 4.x milestone Nov 29, 2023
@bruvzg bruvzg requested a review from a team as a code owner November 29, 2023 09:52
akien-mga
akien-mga reviewed Nov 29, 2023
View reviewed changes
core/string/ustring.cpp Outdated Show resolved Hide resolved
akien-mga
akien-mga approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a Raspberry Pi 5 running Raspberry Pi OS, works fine.

Not a critical problem, but I like my stable releases warning free whenever possible, so this should be good to merge for 4.2.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Nov 29, 2023
@akien-mga akien-mga merged commit 4c5a148 into godotengine:master Nov 29, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the arm_uint8 branch December 1, 2023 12:24
@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Dec 8, 2023
@akien-mga akien-mga changed the title Add unsigned char cast ifdef. Add unsigned char cast ifdef to work around -Wtype-limits warnings Dec 8, 2023
@akien-mga akien-mga mentioned this pull request Dec 8, 2023
Merged
@akien-mga akien-mga added enhancement and removed bug labels Dec 8, 2023
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:linuxbsd topic:buildsystem
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @akien-mga @YuriSizov