Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Make annotations register statically in parser #85487

Merged
merged 1 commit into from
Dec 19, 2023
Merged

GDScript: Make annotations register statically in parser #85487

merged 1 commit into from
Dec 19, 2023

Conversation

vnen
Copy link
Member

@vnen vnen commented Nov 28, 2023

So it only register the annotations once per run instead of doing it every time a script is parsed.

@vnen
GDScript: Make annotations register statically in parser
39e8cf8 
So it only register the annotations once per run instead of doing it
every time a script is parsed.
@vnen vnen requested a review from a team as a code owner November 28, 2023 20:19
dalexeev
dalexeev approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dalexeev dalexeev added this to the 4.3 milestone Dec 2, 2023
@YuriSizov YuriSizov merged commit a6f806f into godotengine:master Dec 19, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@vnen vnen deleted the gdscript-static-register-annotations branch January 2, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexeev dalexeev dalexeev approved these changes

Assignees
No one assigned
Labels
enhancement performance topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@vnen @YuriSizov @dalexeev