Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Fix CharFX character offset calculation. #85363

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 25, 2023

Fixes #85328, new lines were not accounted toward FX character offset.

@bruvzg bruvzg added this to the 4.x milestone Nov 25, 2023
@bruvzg bruvzg requested a review from a team as a code owner November 25, 2023 22:09
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Nov 26, 2023
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 26, 2023
@akien-mga akien-mga merged commit 8580874 into godotengine:master Dec 4, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.1.

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CharFXTransform - relative_index is substracted by 1 each RichTextLabel bbcode effect block
3 participants