Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11: Send IME update notification deferred #85306

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

HolonProduction
Copy link
Member

Fixes #82338
Fixes #82608

I suggest only merging this once the ibus issue is resolved. The error message is not directly linked to the problem with accented characters not inserting, but it will help users who encounter the problem to find the related issue on Github.

Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work! I'm approving this PR, but @bruvzg should have the last word on it.

@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 5, 2023
@akien-mga
Copy link
Member

I suggest only merging this once the ibus issue is resolved. The error message is not directly linked to the problem with accented characters not inserting, but it will help users who encounter the problem to find the related issue on Github.

Isn't this PR meant to workaround the ibus issue? If so it seems good to me to merge this now and cherry-pick for 4.2.1, as we don't know how long it will take for ibus to fix its regression and for Linux distros to pick up the fix.

@adamscott
Copy link
Member

Isn't this PR meant to workaround the ibus issue?

No, it doesn't fix the IBus issue. It fixes the fact that the event is coming from a state where it's not thread-safe for nodes.

@akien-mga
Copy link
Member

I'm still confused, it claims to fix the issues which were pinpointed as caused by the ibus regression.

@adamscott
Copy link
Member

Well, it fixes the ERROR: Caller thread can't call this function in this node (/root). Use call_deferred() or call_thread_group() instead. part.

@bruvzg
Copy link
Member

bruvzg commented Dec 5, 2023

If I understand correctly, this will fix crash with IBus, but not missing dead keys (which is IBus bug).

@akien-mga akien-mga merged commit c442136 into godotengine:master Dec 5, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.1.

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 5, 2023
@HolonProduction HolonProduction deleted the ime-async branch December 9, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants