When saving a resource with an exported typed array, check whether the type is an external resource

[Jordyfel]

Fix #84498

A type of an exported typed array (when it is a script) would not get recognized as an external resource if it was one, which prevented the script from being recognized as a dependency of the resource, which prevented the script path from being updated when moved (since scripts don't have UIDs, that couldn't help either).

Test with test_proj.zip by moving res.gd in and out of the additional dir.

Before:

[gd_scene load_steps=3 format=3 uid="uid://c3fdfa0an52aa"]

[ext_resource type="Script" path="res://main_scene.gd" id="1_vwyik"]
[ext_resource type="Resource" uid="uid://blikieqcyffrc" path="res://new_res.tres" id="3_88yrl"]

[node name="MainScene" type="Node2D"]
script = ExtResource("1_vwyik")
res_twos = Array[Resource("res://res.gd")]([ExtResource("3_88yrl")])

This doesn't allow the script path for the array type to be updated when that script is moved, making the scene unopenable.

After:

[gd_scene load_steps=4 format=3 uid="uid://c3fdfa0an52aa"]

[ext_resource type="Script" path="res://main_scene.gd" id="1_vwyik"]
[ext_resource type="Script" path="res://res.gd" id="2_e4r82"]
[ext_resource type="Resource" uid="uid://blikieqcyffrc" path="res://new_res.tres" id="3_88yrl"]

[node name="MainScene" type="Node2D"]
script = ExtResource("1_vwyik")
res_twos = Array[ExtResource("2_e4r82")]([ExtResource("3_88yrl")])

[AThousandShips]

and an error about the EditorResourcePicker not seeing the type properly (appears very inconsistently).

This needs to be solved assuming it's introduced by this PR

Note that this surfaces other issues, one about gdscipts still being looked for at the old location

This should also not surface due to this PR if avoidable

[Jordyfel]

This should also not surface due to this PR if avoidable

This one doesn't, will edit the OP to be clearer

[Jordyfel]

I don't see how this is a gdscript issue, exporting a typed array is not language specific.

[AThousandShips]

Based it on the specifics of the error report, wasn't possible to tell from it that it wasn't GDScript specific, updated both

[dalexeev]

I didn't find any issues with resource_format_text.cpp, but it doesn't work well with resource_format_binary.cpp. However, it seems that this PR does not introduce new issues, although it does not fix all.

A few notes:

1. Renaming only works through the editor, since scripts do not yet support UID.
2. Old scenes must be saved at least once so that the script path is replaced with ExtResource. Otherwise the issue persists.
3. ResourceLoaderText uses VariantParser which supports SubResource/ExtResource in a unified manner. And ResourceLoaderBinary uses a custom format (even not Marshalls which only support absolute res:// paths for scripts). We should add support for typed arrays in the following places if possible without breaking compatibility:

godot/core/io/resource_format_binary.cpp

Lines 1843 to 1849 in a7b8602

	case Variant::ARRAY: {
	f->store_32(VARIANT_ARRAY);
	Array a = p_property;
	f->store_32(uint32_t(a.size()));
	for (int i = 0; i < a.size(); i++) {
	write_variant(f, a[i], resource_map, external_resources, string_map);
	}

godot/core/io/resource_format_binary.cpp

Lines 495 to 506 in a7b8602

	case VARIANT_ARRAY: {
	uint32_t len = f->get_32();
	Array a; //last bit means shared
	len &= 0x7FFFFFFF;
	a.resize(len);
	for (uint32_t i = 0; i < len; i++) {
	Variant val;
	Error err = parse_variant(val);
	ERR_FAIL_COND_V_MSG(err, ERR_FILE_CORRUPT, "Error when trying to parse Variant.");
	a[i] = val;
	}
	r_v = a;

Given that users typically use tscn/tres (not scn/res) during development, I think we could merge this PR as is, and leave exploring the possibility of fixing binary scenes/resources for later. @Jordyfel Let me know if you want to work on this, otherwise I'll add it to my TODO list.

[akien-mga]

@Jordyfel There's no conflicts, but could you rebase to make sure this passes CI and tests on latest master? The last rebase was a while ago.

[Jordyfel]

Rebased. I do want to try to fix the binary format properly

[dalexeev]

I do want to try to fix the binary format properly

Note that there are currently three kinds of typed arrays. You can see #78219 as an example.

[Jordyfel]

I see that reading and writing would have to be reimplemented in the binary format much like in the marshalls

This makes me wonder, is there even a benefit to the binary format supporting typed arrays. It doesn't now and it hasn't come up.

[akien-mga]

Thanks!