-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C# example for the AudioStreamGenerator code snippet #84648
Conversation
Thanks for the contribution! I pointed out some code style issues in the example which should be solved. The best way to do it is by amending the commit so that it stays as a single commit in this PR, which is the way we'd want to merge such a documentation improvement. While at it, please also update the commit message to be more explicit (e.g. reusing what I put as PR title). "Update file" doesn't say what the update does so it's not a good informative commit message. |
I've made the changes but I think something went wrong the the amendment and now there are two commits instead of one. I did try to squash them but git wouldn't let me due to the commits having multiple parents :( |
I squashed the commits for you, it wasn't trivial indeed after the latest changes, not sure how the Git history ended up exactly. I also fixed a few formatting issues (trailing whitespace, |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Added a C# example for the AudioStreamGenerator code snippet.