Use Python venv if detected when building VS project #84593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:buildsystem
cherrypick:4.1
akien-mga
changed the title
yedpodtrzitko
approved these changes
Nov 27, 2023
akien-mga
approved these changes
Nov 29, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.1. |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #84555
this works for me and solves my problem. I want to use a
venvto isolate my scons installation from the rest of my system but using it is incompatible with the generatedgodot.slnsince the call tosconsassumes it's installed globally.If a virtual environment is activated, the
VIRTUAL_ENVenv var should contain a path to its root, and from there we can build the proper command.No hard feelings if we don't wanna merge this, but it's useful to me ;)