-
-
Notifications
You must be signed in to change notification settings - Fork 22.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix material drag and drop #84486
Fix material drag and drop #84486
Conversation
@SaracenOne you might be interested in looking at this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Though it doesn't quite fix it completely because the issue persists when using per-surface overrides (with the CTRL modifier).
My suggestion for fixing this fully is adding:
spatial_editor->set_preview_material_surface(-1);
to line 4255
And removing it from line 4274
Weird, I test it with CTRL and seems to be fixed. But I will re-test and try your solution |
f63348c
to
aa2522e
Compare
@SaracenOne I applied that change. Seems to work fine I also tried to remove the material override when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks! And congrats for your first merged Godot contribution 🎉 |
@akien-mga thanks <3 |
My first PR 😄
Fixes: #74077
Explanation: When dragging over meshes with the same material (as the one dragged) and going over other mesh, material preview were reset but never assign again, causing to have a wrong state