Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visual shader's screen_uv input preview uses position of node rather than a sample area like uv #84348

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix visual shader's screen_uv input preview uses position of node rather than a sample area like uv #84348

merged 1 commit into from
Jan 4, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #84311

@jsjtxietian jsjtxietian requested a review from a team as a code owner November 2, 2023 07:51
@Chaosus Chaosus added this to the 4.2 milestone Nov 2, 2023
@clayjohn clayjohn modified the milestones: 4.2, 4.3 Nov 2, 2023
@clayjohn clayjohn added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Nov 2, 2023
@Chaosus
Copy link
Member

Chaosus commented Nov 5, 2023

@jsjtxietian I think this is incorrect place for doing this code, the correct place is

godot/scene/resources/visual_shader.cpp

Line 3141 in 5ee9831

{ Shader::MODE_SPATIAL, VisualShader::TYPE_FRAGMENT, VisualShaderNode::PORT_TYPE_VECTOR_2D, "screen_uv", "SCREEN_UV" },

@jsjtxietian
Copy link
Contributor Author

Ah, yes, that's a more elegant approach, thanks!

@jsjtxietian jsjtxietian force-pushed the screen-uv-in-visual-shader-preview-should-uv branch from 623f137 to 185c89e Compare November 6, 2023 03:19
@jsjtxietian jsjtxietian force-pushed the screen-uv-in-visual-shader-preview-should-uv branch from 185c89e to d920bde Compare November 6, 2023 03:20
@akien-mga akien-mga changed the title Fix visual shader's screen_uv input preview uses position of node rather than a sample area like uv Fix visual shader's screen_uv input preview uses position of node rather than a sample area like uv Nov 9, 2023
@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 4, 2024
@akien-mga akien-mga merged commit 5d30620 into godotengine:master Jan 4, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the screen-uv-in-visual-shader-preview-should-uv branch January 5, 2024 02:22
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chaosus Chaosus Chaosus approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:shaders
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

VisualShader editor input screen_uv preview uses visual position of node in editor rather than a sample area
4 participants
@jsjtxietian @Chaosus @akien-mga @clayjohn