Fix documentation in MultiplayerAPIExtension #84226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
approved these changes
Oct 31, 2023
akien-mga
reviewed
Oct 31, 2023
Faless
reviewed
Oct 31, 2023
|
Looks good! Could you squash the commits? See PR workflow for instructions. |
|
Commits squashes, thanks for the link. |
|
Last adjustment, could you amend the commit message so that the title is "Fix documentation in MultiplayerAPIExtension" instead of the current "Update doc/classes/MultiplayerAPIExtension.xml"? And you can probably drop the line making @Faless a co-author, he just provided some style fix suggestions. |
AThousandShips
changed the title
Fix documentation in MultiplayerAPIExtension.xml In implementing a MultiplayerAPIExtension, I found that the example from documentation did not function even in the Multiplayer tutorial example. Eventually, I found that the issue was that base_multiplayer will not poll unless told to by the LogMultiplayer implementation. I also corrected a spelling issue and a few out-of-date return types.
|
Updated Thanks for the help on doing a PR, I haven't done it for public repos before. |
akien-mga
approved these changes
Nov 1, 2023
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In implementing a MultiplayerAPIExtension, I found that the example from documentation did not function even in the Multiplayer tutorial example.
Eventually, I found that the issue was that base_multiplayer will not poll unless told to by the LogMultiplayer implementation. With my changes, the example code compiles and functions in that project in 4.1.
I also corrected a spelling issue and a few out-of-date return types.