Particles: Fix directed points not working, and fix friction formula #83831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
akien-mga
reviewed
Oct 23, 2023
Co-authored-by: RPicster <picster@pixelgod.net>
QbieShay
force-pushed
the
qbe/fix-normal-point
branch
from
4b3af39
to
49fee5b
Compare
AThousandShips
approved these changes
Oct 23, 2023
akien-mga
changed the title
clayjohn
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Looks good.
For a future PR we need to go back and clean up emission_tex_size and just store the size. Each call to textureSize() has the same cost as a texture read, which adds a lot to the cost of particles. But since this is an existing issue in the code, let's do that in a follow up PR
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83811
Fixes friction formula. It was supposed to be like this when i made it, but i just lost track of it so it stayed with a wrong formula. Video comparison:
Left current, Right updated.
https://github.com/godotengine/godot/assets/7917475/1b485e35-66dd-4801-b713-00d6b9aa5bba
Credit to @RPicster for the formula