Add pivot editing to UV editor #83612
Open
+36
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aXu-AP
force-pushed
the
uv-editor-pivot
branch
from
c513837 to
ef553fd
Compare
aXu-AP
force-pushed
the
uv-editor-pivot
branch
from
ef553fd to
fc16a4c
Compare
Add draggable pivot marker to UV editors Points mode. Bonus: Fix UV editor using hardcoded value instead of editor setting polygon_editor/point_grab_radius.
aXu-AP
force-pushed
the
uv-editor-pivot
branch
from
fc16a4c to
c4ca6a2
Compare
KoBeWi
reviewed
Oct 6, 2024
| @@ -1239,6 +1264,11 @@ void Polygon2DEditor::_uv_draw() { | |||
| } | |||
| } | |||
|
|
|||
| if (uv_edit_mode[1]->is_pressed()) { | |||
There was a problem hiding this comment.
Unrelated, but the modes should get an enum.
EDIT:
I see there are some enums already, but for something different. uv_edit_mode values are still hard-coded, which is bad.
There was a problem hiding this comment.
Yeah this code is a bit all over the place and there's some confusing terminology for modes, actions and menu items. I've outlined some refactoring work which I want to do in godotengine/godot-proposals#8209 (input on those points would be appreciated).
KoBeWi
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements partially godotengine/godot-proposals#4118
Shows draggable pivot point in UV editor when Points mode is selected. Priority is given to dragging vertices to avoid accidentally moving pivot.
Bonus: Fix UV editor using hardcoded value instead of editor setting
polygon_editor/point_grab_radius.