Mesh instance UV2 unwrapping improvements #83498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 26, 2023
SaracenOne
force-pushed
the
mesh_unwrap_rules
branch
from
06f18e8
to
17a37f9
Compare
|
Updated, removed redundant explicit casting. |
akien-mga
approved these changes
Oct 26, 2023
Enforce foreign resource modification rules. Add more helpful error handling for ArrayMesh unwrapping.
SaracenOne
force-pushed
the
mesh_unwrap_rules
branch
from
17a37f9
to
e865bad
Compare
|
Fixed |
|
Thanks! |
| err_dialog->set_text(TTR("Mesh cannot unwrap UVs because it belongs to another resource which was imported from another file type. Make it unique first.")); | ||
|
|
||
| uint64_t format = array_mesh->surface_get_format(i); | ||
| if (format & Mesh::ArrayFormat::ARRAY_FORMAT_NORMAL) { |
There was a problem hiding this comment.
Is this not backwards? It checks that it has normals and throws an error if it does, it should be:
if (!(format & Mesh::ArrayFormat::ARRAY_FORMAT_NORMAL)) {
Right?
There was a problem hiding this comment.
For future readers, continue to #84374.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new option to set the unwrap mesh UV2 option in PrimitiveMeshes from the MeshInstance3DEditorPlugin now respects the global rules which disallows modifications to foreign resources and pre-emptively shows more informative error messages for common ArrayMesh unwrapping fail cases rather than conveying a generic popup error message and providing the actual information as a notification.