Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add brief description in GDExtension API dump with docs #83318

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add brief description in GDExtension API dump with docs #83318

merged 1 commit into from
Oct 16, 2023

Conversation

rburing
Copy link
Member

@rburing rburing commented Oct 14, 2023 •
edited
Loading

Also rename the "documentation" key to "description" for internal consistency, as discussed on RocketChat. The rename should be okay since this feature has only been in dev releases and one beta release so far.

Follow-up to

@rburing
Add brief description in GDExtension API dump with docs
c87b2a6 
Also rename the "documentation" key to "description" for internal
consistency.
@rburing rburing added this to the 4.2 milestone Oct 14, 2023
@rburing rburing requested a review from a team as a code owner October 14, 2023 10:20
dsnopek
dsnopek approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This makes sense! I didn't test but skimming the code, it looks good to me

@akien-mga akien-mga merged commit c7b75c0 into godotengine:master Oct 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@rburing rburing deleted the gdextension_dump_brief_description branch October 18, 2023 18:59
@rburing rburing mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:gdextension
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@rburing @akien-mga @dsnopek