Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThorVG: update to v0.11.1 #83281

Merged
merged 1 commit into from
Oct 16, 2023
Merged

ThorVG: update to v0.11.1 #83281

merged 1 commit into from
Oct 16, 2023

Conversation

capnm
Copy link
Contributor

@capnm capnm commented Oct 13, 2023 •
edited
Loading

https://github.com/thorvg/thorvg/releases/tag/v0.11.1

Godot related:

  • [SwEngine] Enhanced the quality of the dash line corners.

image

  • [SVG] Fixed a regression bug related to maskContentUnits userSpaceOnUse/objectBoundingBox.

Fixes #82982 - icons

img02

Fixes #83198 - svg ← png/jpg

@capnm capnm requested review from a team as code owners October 13, 2023 16:39
@fire
Copy link
Member

fire commented Oct 13, 2023 •
edited
Loading

Waiting for the cicd to build, and a regression test on raster images like jpg,png in svg

@capnm
Copy link
Contributor Author

capnm commented Oct 13, 2023 •
edited
Loading

embeded_png_jpg.zip

image

@Calinou Calinou added this to the 4.2 milestone Oct 13, 2023
@Calinou Calinou added the bug label Oct 13, 2023
@fire
Copy link
Member

fire commented Oct 14, 2023

What was reported was that png works, but we are waiting on the jpeg fix on thorvg.

@fire
Copy link
Member

fire commented Oct 15, 2023

Upstream made an update, waiting for a release.

@capnm
ThorVG: Update to v0.11.1
0983022 
https://github.com/thorvg/thorvg/releases/tag/v0.11.1

Godot related:
+ [SwEngine] Enhanced the quality of the dash line corners.
+ [SVG] Fixed a regression bug related to maskContentUnit,
	userSpaceOnUse/objectBoundingBox.

Fixes godotengine#82982 icons.
Fixes godotengine#83198 svg ← png/jpg.
@akien-mga akien-mga merged commit 9ca1d78 into godotengine:master Oct 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@capnm capnm deleted the thorvg_0.11.1 branch October 16, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug enhancement topic:import topic:thirdparty
Projects
None yet
Milestone
4.2
4 participants
@capnm @fire @akien-mga @Calinou