Move 2D-only editor plugins to their own folder #83161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
editor-plugins-2d
branch
from
db0fe38
to
3087417
Compare
aaronfranke
force-pushed
the
editor-plugins-2d
branch
from
3087417
to
26df7ef
Compare
aaronfranke
force-pushed
the
editor-plugins-2d
branch
from
26df7ef
to
3ac3bb7
Compare
aaronfranke
force-pushed
the
editor-plugins-2d
branch
from
3ac3bb7
to
0c21955
Compare
aaronfranke
force-pushed
the
editor-plugins-2d
branch
2 times, most recently
from
97775ab
to
60e27f6
Compare
aaronfranke
force-pushed
the
editor-plugins-2d
branch
from
60e27f6
to
f847c6c
Compare
aaronfranke
force-pushed
the
editor-plugins-2d
branch
from
f847c6c
to
5b84908
Compare
aaronfranke
force-pushed
the
editor-plugins-2d
branch
from
5b84908
to
d61bf05
Compare
aaronfranke
force-pushed
the
editor-plugins-2d
branch
from
d61bf05
to
10b9b1b
Compare
aaronfranke
force-pushed
the
editor-plugins-2d
branch
from
10b9b1b
to
c424700
Compare
aaronfranke
force-pushed
the
editor-plugins-2d
branch
from
c424700
to
df9ba2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves 2D-only editor plugins to their own folder. Specifically, this folder contains files only needed for editing Node2D, but not Node3D or Control nodes (so
canvas_item_editor_plugindoes not go in this folder). This PR is similar to how we havescene/2dfolder for 2D nodes, and is in a similar vain to several other PRs I've opened.Q: Why these specific files? How do you know to put these files in a folder and that you're not missing any?
A: I have another branch where I have the ability to completely disable Node2D in editor builds. This gives me evidence that the files I've moved are the correct ones. I don't expect that to get merged, but I do think file organization is worth upstreaming, it's more organized to have the 2D editor files all together.
Q: What about moving 3D-only editor plugins to their own folder?
A: The 3D editor code is much more deeply integrated, it would be a much larger task to do like I did above with creating a branch that can compile the editor without 3D as evidence for which files should be moved where. This is something I would like to have eventually, though, for improved separation, isolation, and organization.