Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tooltip for metadata in the inspector #83072

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve tooltip for metadata in the inspector #83072

wants to merge 1 commit into from
+6 −1

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 9, 2023 •
edited
Loading

Since metadata can't have a description filled in, this adds usage instructions for the metadata instead.

Preview

image

@Calinou Calinou added this to the 4.x milestone Oct 9, 2023
@dalexeev
Copy link
Member

Since the inline code appears mangled due to not having enough line spacing, I'm marking the PR as a draft

I think this is not specific to this PR, it's an EditorHelpBit issue that already exists in several places.

@Calinou Calinou force-pushed the editor-tooltip-metadata-improve-description branch from 8a496eb to a4293a2 Compare October 14, 2023 17:57
@Calinou
Improve tooltip for metadata in the inspector
5b73724 
Since metadata can't have a description filled in, this adds usage
instructions for the metadata instead.
@Calinou Calinou force-pushed the editor-tooltip-metadata-improve-description branch from a4293a2 to 5b73724 Compare January 31, 2024 01:30
@Calinou Calinou marked this pull request as ready for review January 31, 2024 01:30
ryevdokimov
ryevdokimov reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@ryevdokimov ryevdokimov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the use of italics for the whole description intentional? Not saying it's wrong, just wanted to understand the reasoning, when compared to the rest of the helper popups.

@Calinou
Copy link
Member Author

Calinou commented Feb 1, 2024

Is the use of italics for the whole description intentional? Not saying it's wrong, just wanted to understand the reasoning, when compared to the rest of the helper popups.

Yes, because it's an automatically generated description as opposed to one manually supplied by the script author.

ryevdokimov
ryevdokimov approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@ryevdokimov ryevdokimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryevdokimov ryevdokimov ryevdokimov approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @dalexeev @ryevdokimov