Show revert button for MeshInstance3D blendshape values #82984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows revert button for MeshInstance3D blendshape values.
smix8
force-pushed
the
revert_blendshapes_4.x
branch
from
895790e
to
2dfa023
Compare
akien-mga
reviewed
Feb 22, 2024
Comment on lines
+497
to
+501
| HashMap<StringName, int>::ConstIterator E = blend_shape_properties.find(p_name); | ||
| if (E) { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Just to be sure, can you confirm that this doesn't break the revertability of other, non blend shape properties of MeshInstance3D?
There was a problem hiding this comment.
I can confirm that I can still revert all the Node3D/GeometryInstance3D inspector properties that seem to be the only class in the inherit chain that uses the same functions. Everything else about that function shenanigan and how it does its thing under the hood no idea, I am just monkey-copy-pasting from other nodes.
There was a problem hiding this comment.
false means fallback to default behavior, like with other similar methods.
KoBeWi
approved these changes
Feb 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows revert button for MeshInstance3D blendshape values.
... because having to enter
0.0manually all the time because the slider steps make it impossible to hit zero needs to stop.