Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] Remove unnecessary glyph position rounding. #82970

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[RTL] Remove unnecessary glyph position rounding. #82970

merged 1 commit into from
Oct 9, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 7, 2023

Removes rounding introduced it #77819, glyphs can use subpixel rendering and is not necessary rendered at integer positions.

@bruvzg bruvzg added this to the 4.2 milestone Oct 7, 2023
@bruvzg bruvzg requested a review from a team as a code owner October 7, 2023 15:08
@lmurray

This comment was marked as outdated.

Sign in to view
@bruvzg bruvzg marked this pull request as draft October 8, 2023 09:37
@bruvzg
Copy link
Member Author

bruvzg commented Oct 9, 2023

This rounding was added by #79705.

Removed this part.

@bruvzg bruvzg marked this pull request as ready for review October 9, 2023 05:44
@akien-mga akien-mga merged commit 4f85375 into godotengine:master Oct 9, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @lmurray @akien-mga