Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Bounce = 1.0 not being sufficient for infinite energy conservation #82968

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Document Bounce = 1.0 not being sufficient for infinite energy conservation #82968

merged 1 commit into from
Feb 27, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 7, 2023

@Calinou Calinou requested a review from a team as a code owner October 7, 2023 14:58
@Calinou Calinou added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 7, 2023
@Calinou Calinou added this to the 4.2 milestone Oct 7, 2023
AThousandShips
AThousandShips reviewed Oct 7, 2023
View reviewed changes
doc/classes/PhysicalBone3D.xml Outdated Show resolved Hide resolved
doc/classes/PhysicsMaterial.xml Outdated Show resolved Hide resolved
@YuriSizov YuriSizov modified the milestones: 4.2, 4.3 Nov 10, 2023
@YuriSizov YuriSizov added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release and removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Nov 10, 2023
Mickeon
Mickeon approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good information, even if the note itself is extremely detailed, perhaps too much.
I would tone these instructions down by a large margin but I won't cry myself to sleep about it.

doc/classes/PhysicsMaterial.xml Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit 7c0461a into godotengine:master Feb 27, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Mar 11, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.

@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 11, 2024
@Calinou Calinou deleted the doc-physics-bounce-damping branch March 26, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Rigidbody lose bounce enegy with bounce 1
5 participants
@Calinou @akien-mga @Mickeon @AThousandShips @YuriSizov