Allow to remove signal connections using Delete

[Madalaski]

This pull request improves usability with the Node connection panel, to allow the user to quickly delete connections by pressing the DEL key.

The _rmb_pressed method in the ConnectionsDock class has been renamed to _gui_input to reflect the new handling of other inputs.

This fixes the usability issue outlined in #82616.

• Bugsquad edit, closes: Pressing DEL on selected signals should delete them #82616

[MewPurPur]

Comment style nitpicks. I don't see an issue in the rest, other than I don't think connection needs to be initialized as it's only used once.

[akien-mga]

Please amend the commit message so it's meaningful, "Initial Commit" isn't a very good description for this change ;)
See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind

[Madalaski]

Comment style nitpicks. I don't see an issue in the rest, other than I don't think connection needs to be initialized as it's only used once.

Cheers, should've been more careful with the comments. I got an error when I removed the connection initialisation. From the looks of it, connection uses a Variant() operation to convert get_metadata()'s return to Connection and then an implicit conversion in the method call into ConnectionData.

Please amend the commit message so it's meaningful, "Initial Commit" isn't a very good description for this change ;) See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind

Done! 😄

[MewPurPur]

Makes sense then to keep it then

[dalexeev]

Please squash commits into one. To do this you need a local git client, GitHub web interface doesn't support it.

[dalexeev]

Looks good to me. Note that when the Script workspace is open, you can press Delete regardless of the mouse cursor position. But when a 2D or 3D workspace is open, the cursor must be inside the Connection Editor, otherwise deleting a node in the Scene Tree will be triggered. This is not directly related to this PR, just a note.

[YuriSizov]

Thanks! And congrats on your first merged Godot pull request!