Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit animation audio clip inspector offset sliders to clip length #82627

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Limit animation audio clip inspector offset sliders to clip length #82627

merged 1 commit into from
Oct 16, 2023

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Oct 1, 2023

Resolves #61630.

Before After
LgFgJMgh7D cJoro95bWw

@kleonc kleonc added enhancement topic:editor usability cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:animation labels Oct 1, 2023
@kleonc kleonc added this to the 4.2 milestone Oct 1, 2023
@fire fire requested a review from a team October 1, 2023 22:44
SaracenOne
SaracenOne approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and the implementation seems good.

@akien-mga akien-mga merged commit e897a46 into godotengine:master Oct 16, 2023
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the animation-editor-audio-clip-offset-sliders-limit-to-length branch October 16, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees
No one assigned
Labels
cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:animation topic:editor usability
Projects
None yet
Milestone
4.2
3 participants
@kleonc @akien-mga @SaracenOne