Document get_time_zone_from_system will return a localized timezone name
#82609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
reviewed
Oct 30, 2023
YuriSizov
approved these changes
Oct 30, 2023
akien-mga
changed the title
get_time_zone_from_system will return a localized timezone name
jsjtxietian
force-pushed
the
document-localized-timezone-name
branch
from
4bef2e8
to
5eeb151
Compare
|
Thanks! |
|
My suggestion wasn't completely addressed, the phrasing in the last sentence is still the same as before, and I think it needs to be clarified. |
|
@YuriSizov Ah sorry! I missed the second line of your suggestion! Should I make another pr and clarify this? |
|
Yes, please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the doc as mentioned in #82361