Add more context to some Window errors
#82590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Sep 30, 2023
YuriSizov
force-pushed
the
window-you-come-to-me-on-this-day-the-day-when-my-child-becomes-exclusive-with-a-transient-parent-to-ask-for-this
branch
from
7b17bf7 to
53172d9
Compare
bruvzg
approved these changes
Sep 30, 2023
|
Thanks! |
YuriSizov
deleted the
window-you-come-to-me-on-this-day-the-day-when-my-child-becomes-exclusive-with-a-transient-parent-to-ask-for-this
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some error messages throughout the engine which have pretty vague statements in them, without pointing to any specific context. This PR addresses a couple such examples in
Window(andControl).Mainly, this PR unifies the checks and the error message for the infamous transient parent exclusive child operation, and adds some details about the current node, the parent, and the other child that conflicts with our current node. Since this message can happen in the editor without much user agenda, we need all 3 to understand where it's coming from.
For example, we have this issue with the MSBuild panel when building fails:
Seems like the progress bar that appears during the build conflicts with the error message that we pop at the end. This wasn't so obvious before and required more debugging and digging. (cc @raulsntos this should help!)
PS. Rest in peace, "Transient parent has another exclusive child." You are "Attempting to make child window exclusive, but the parent window already has another exclusive child." now.