Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening docs writing extra navigation history #82498

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

aXu-AP
Copy link
Contributor

@aXu-AP aXu-AP commented Sep 28, 2023

Fix #82292
Removes extraneous call to change the tab if the page wasn't yet open when opening class member description.

Fix godotengine#82292
Removes extraneous call to change the tab if the page wasn't yet open when opening class member description.
@aXu-AP aXu-AP requested a review from a team as a code owner September 28, 2023 21:05
@Chaosus Chaosus added this to the 4.2 milestone Sep 29, 2023
@YuriSizov YuriSizov modified the milestones: 4.2, 4.3 Nov 10, 2023
@YuriSizov YuriSizov added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 10, 2023
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, I confirm that the remaining code is sufficient to change the tab to the relevant help page and then scroll to the position.

@akien-mga akien-mga merged commit ee42c9e into godotengine:master Jan 9, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@aXu-AP aXu-AP deleted the docs-double-navigation branch January 10, 2024 10:16
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening member description in docs causes extra navigation
4 participants