Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in heuristic_euclidian helper in AStarGrid2D #81778

Closed
wants to merge 2 commits into from
Closed

Fix typo in heuristic_euclidian helper in AStarGrid2D #81778

wants to merge 2 commits into from

Conversation

sadikkuzu
Copy link
Contributor

No description provided.

@sadikkuzu sadikkuzu requested a review from a team as a code owner September 17, 2023 00:54
@AThousandShips AThousandShips added this to the 4.2 milestone Sep 17, 2023
@sadikkuzu
Copy link
Contributor Author

I do not know how to overcome GHA / Linux / Editor with doubles and GCC sanitizers check.

Could you please help me?

image

image

@AThousandShips
Copy link
Member

It's unrelated, random issue:

@sadikkuzu
Copy link
Contributor Author

Oh, ok, thank you @AThousandShips 🙏🏼

@akien-mga akien-mga changed the title Fix typo in a_star_grid_2d.cpp Fix typo in heuristic_euclidian helper in AStarGrid2D Sep 25, 2023
@akien-mga
Copy link
Member

Could you rebase to remove the merge commit? This PR should only have a single commit. I would also suggest rewording the commit message to be more explicit (like I did with the PR title).

@sadikkuzu
Copy link
Contributor Author

Will go on with #82297

@sadikkuzu sadikkuzu closed this Sep 25, 2023
@sadikkuzu sadikkuzu deleted the patch-1 branch September 25, 2023 11:36
@AThousandShips AThousandShips removed this from the 4.2 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived bug topic:codestyle topic:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadikkuzu @AThousandShips @akien-mga