Fix saving editor folder colors #81344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should check if the setting exists. Setting it is only needed when it doesn't. |
|
Am just about to push that change, was testing it out |
Also clears setting if none are assigned
AThousandShips
force-pushed
the
folder_color_fix
branch
from
f79eab4
to
1083ce4
Compare
AThousandShips
commented
Sep 5, 2023
| if (!ProjectSettings::get_singleton()->has_setting("file_customization/folder_colors")) { | ||
| ProjectSettings::get_singleton()->set_setting("file_customization/folder_colors", assigned_folder_colors); | ||
| } else if (assigned_folder_colors.is_empty()) { | ||
| ProjectSettings::get_singleton()->set_setting("file_customization/folder_colors", Variant()); |
There was a problem hiding this comment.
Can remove if wanted, but thought it'd be good to avoid taking up space in the settings if nothing is configured
KoBeWi
approved these changes
Sep 5, 2023
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clears the setting if no folder is configured
If the addition of folder colors are added to the release blog post I think adding a note about it not currently working would be good