Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency for NodePath doc code examples #80443

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Consistency for NodePath doc code examples #80443

merged 1 commit into from
Aug 9, 2023

Conversation

gio3k
Copy link
Contributor

@gio3k gio3k commented Aug 9, 2023

Just makes a code example in NodePath.xml similar to the others

Just makes a code example in NodePath.xml similar to the others
@gio3k gio3k requested a review from a team as a code owner August 9, 2023 09:21
@AThousandShips AThousandShips added this to the 4.x milestone Aug 9, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 9, 2023
@akien-mga
Copy link
Member

Confirmed to be the only occurrence of that specific example:

$ rg -g'*.xml' "var nodepath"
doc/classes/NodePath.xml
104:                            var nodepath = NodePath("Path2D/PathFollow2D/Sprite2D:texture:load_path")
108:                            var nodepath = new NodePath("Path2D/PathFollow2D/Sprite2D:texture:load_path");
$ rg -g'*.xml' "var node_path"
doc/classes/NodePath.xml
77:                             var node_path = NodePath("position:x")
121:                            var node_path = NodePath("Path2D/PathFollow2D/Sprite2D")
149:                            var node_path = NodePath("Path2D/PathFollow2D/Sprite2D:texture:load_path")

@akien-mga akien-mga merged commit d76b97e into godotengine:master Aug 9, 2023
15 checks passed
@akien-mga
Copy link
Member

akien-mga commented Aug 9, 2023

Thanks! And congrats for your first merged Godot contribution 🎉

@gio3k gio3k deleted the lotuspar-patch-1 branch August 10, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants