Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cosmetic improvements in the GLTF code #80205

Merged

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Aug 3, 2023

  • Fix an inconsistency of r_state vs p_state, inverts the change in Improve GLTF export logic for scene root nodes #79801, now it uses p_state.
  • Improve documentation of GLTFDocument.
  • Rename texture_dir to relative_texture_dir since it's relative to the GLTF file.
  • Rename new_texture_dir to full_texture_dir since it's the full directory path.
  • Rename Dictionary d to image_dict.
  • Rename Dictionary d to texture_dict and Ref<GLTFTexture> t to gltf_texture.
  • Remove unnecessary Area3D include.

Several of these were taken from #79314, split off for easier reviewing.

@aaronfranke aaronfranke force-pushed the gltf-cosmetic-2-electric-boogaloo branch from d43c857 to bc68fa3 Compare August 3, 2023 07:06
@akien-mga akien-mga merged commit d191a2f into godotengine:master Aug 3, 2023
14 checks passed
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the gltf-cosmetic-2-electric-boogaloo branch August 3, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants