Expose Window's _get_contents_minimum_size() to scripting
#80178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeldhamDev
force-pushed
the
override_all_the_things
branch
from
320330e to
f270163
Compare
YuriSizov
approved these changes
Aug 2, 2023
akien-mga
reviewed
Aug 3, 2023
Comment on lines
+1751
to
+1752
| Vector2 ms = _get_contents_minimum_size(); | ||
| GDVIRTUAL_CALL(_get_contents_minimum_size, ms); |
There was a problem hiding this comment.
Isn't it going to be wasteful to always run the default _get_contents_minimum_size() before the virtual call? How heavy is that call?
Not tested, but this might be better for performance:
Suggested change
| Vector2 ms = _get_contents_minimum_size(); | |
| GDVIRTUAL_CALL(_get_contents_minimum_size, ms); | |
| Vector2 ms; | |
| if (GDVIRTUAL_CALL(_get_contents_minimum_size, ms) { | |
| return ms; | |
| } | |
| return _get_contents_minimum_size(); |
|
Thanks! Didn't intend to merge it just yet, made a mistake in my batch... oh well. |
|
A follow-up would be good still, the change you suggested does make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_get_contents_minimum_size()method is used by Godot'sAccept/ConfirmationDialog, and it would be very useful for users that intend to make dialogs with custom behavior.