Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShaderInclude class icon #80129

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented Aug 1, 2023

image

Seemed like a better option than something abstract like a jigsaw edge

Also fixes a few icons where I forgot to add the xml namespace. This didn't bring issues into Godot, but some renderers wouldn't handle those icons properly (e.g. my OS's previews). So it's best to just include that annoying header.

@MewPurPur MewPurPur requested a review from a team as a code owner August 1, 2023 17:40
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 2, 2023
@akien-mga akien-mga merged commit 6adc25e into godotengine:master Aug 2, 2023
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the shader-include-icon branch August 2, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants